Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add IAM Identity Center module #249

Merged
merged 10 commits into from
Apr 11, 2024
Merged

feat: add IAM Identity Center module #249

merged 10 commits into from
Apr 11, 2024

Conversation

patheard
Copy link
Member

@patheard patheard commented Apr 9, 2024

Summary

Add a module that can manage the IAM Identity Center groups, permission sets and account assignments.

This includes the GitHub workflow changes and the GC Articles target state group and account assignments.

Related

Add a module that can manage the IAM Identity Center groups,
permission sets and account assignments.

This PR includes the GitHub workflow changes and the GC Articles group
and account assignments.
@patheard patheard self-assigned this Apr 9, 2024
@patheard patheard marked this pull request as ready for review April 9, 2024 15:01
@patheard patheard requested a review from a team April 9, 2024 15:03
Copy link
Member

@wanpengyang wanpengyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

Plan for org_account/iam_identity_center

✅   Terraform Init: success
✅   Terraform Validate: success
✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

Plan: 12 to add, 0 to change, 0 to destroy
Show summary
CHANGE NAME
add aws_identitystore_group.articles_production_access_vpc_clientvpn
aws_identitystore_group.articles_production_admin
aws_identitystore_group.articles_production_read_only
aws_identitystore_group.articles_staging_access_vpc_clientvpn
aws_identitystore_group.articles_staging_admin
aws_identitystore_group.articles_staging_read_only
aws_ssoadmin_account_assignment.articles["Articles-Production-Admin-472286471787"]
aws_ssoadmin_account_assignment.articles["Articles-Production-Admin-762579868088"]
aws_ssoadmin_account_assignment.articles["Articles-Production-ReadOnly-472286471787"]
aws_ssoadmin_account_assignment.articles["Articles-Production-ReadOnly-762579868088"]
aws_ssoadmin_account_assignment.articles["Articles-Staging-Admin-729164266357"]
aws_ssoadmin_account_assignment.articles["Articles-Staging-ReadOnly-729164266357"]
Show plan
Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # aws_identitystore_group.articles_production_access_vpc_clientvpn will be created
  + resource "aws_identitystore_group" "articles_production_access_vpc_clientvpn" {
      + description       = "Grants members access to the GC Articles Production Client VPN."
      + display_name      = "Articles-Production-Access-VPC-ClientVPN"
      + external_ids      = (known after apply)
      + group_id          = (known after apply)
      + id                = (known after apply)
      + identity_store_id = "d-9d67173bdd"
    }

  # aws_identitystore_group.articles_production_admin will be created
  + resource "aws_identitystore_group" "articles_production_admin" {
      + description       = "Grants members administrator access to the GC Articles Production account."
      + display_name      = "Articles-Production-Admin"
      + external_ids      = (known after apply)
      + group_id          = (known after apply)
      + id                = (known after apply)
      + identity_store_id = "d-9d67173bdd"
    }

  # aws_identitystore_group.articles_production_read_only will be created
  + resource "aws_identitystore_group" "articles_production_read_only" {
      + description       = "Grants members read-only access to the GC Articles Production account."
      + display_name      = "Articles-Production-ReadOnly"
      + external_ids      = (known after apply)
      + group_id          = (known after apply)
      + id                = (known after apply)
      + identity_store_id = "d-9d67173bdd"
    }

  # aws_identitystore_group.articles_staging_access_vpc_clientvpn will be created
  + resource "aws_identitystore_group" "articles_staging_access_vpc_clientvpn" {
      + description       = "Grants members access to the GC Articles Staging Client VPN."
      + display_name      = "Articles-Staging-Access-VPC-ClientVPN"
      + external_ids      = (known after apply)
      + group_id          = (known after apply)
      + id                = (known after apply)
      + identity_store_id = "d-9d67173bdd"
    }

  # aws_identitystore_group.articles_staging_admin will be created
  + resource "aws_identitystore_group" "articles_staging_admin" {
      + description       = "Grants members administrator access to the GC Articles Staging account."
      + display_name      = "Articles-Staging-Admin"
      + external_ids      = (known after apply)
      + group_id          = (known after apply)
      + id                = (known after apply)
      + identity_store_id = "d-9d67173bdd"
    }

  # aws_identitystore_group.articles_staging_read_only will be created
  + resource "aws_identitystore_group" "articles_staging_read_only" {
      + description       = "Grants members read-only access to the GC Articles Staging account."
      + display_name      = "Articles-Staging-ReadOnly"
      + external_ids      = (known after apply)
      + group_id          = (known after apply)
      + id                = (known after apply)
      + identity_store_id = "d-9d67173bdd"
    }

  # aws_ssoadmin_account_assignment.articles["Articles-Production-Admin-472286471787"] will be created
  + resource "aws_ssoadmin_account_assignment" "articles" {
      + id                 = (known after apply)
      + instance_arn       = "arn:aws:sso:::instance/ssoins-8824c710b5ddb452"
      + permission_set_arn = "arn:aws:sso:::permissionSet/ssoins-8824c710b5ddb452/ps-37cc13ae63647ac6"
      + principal_id       = (known after apply)
      + principal_type     = "GROUP"
      + target_id          = "472286471787"
      + target_type        = "AWS_ACCOUNT"
    }

  # aws_ssoadmin_account_assignment.articles["Articles-Production-Admin-762579868088"] will be created
  + resource "aws_ssoadmin_account_assignment" "articles" {
      + id                 = (known after apply)
      + instance_arn       = "arn:aws:sso:::instance/ssoins-8824c710b5ddb452"
      + permission_set_arn = "arn:aws:sso:::permissionSet/ssoins-8824c710b5ddb452/ps-37cc13ae63647ac6"
      + principal_id       = (known after apply)
      + principal_type     = "GROUP"
      + target_id          = "762579868088"
      + target_type        = "AWS_ACCOUNT"
    }

  # aws_ssoadmin_account_assignment.articles["Articles-Production-ReadOnly-472286471787"] will be created
  + resource "aws_ssoadmin_account_assignment" "articles" {
      + id                 = (known after apply)
      + instance_arn       = "arn:aws:sso:::instance/ssoins-8824c710b5ddb452"
      + permission_set_arn = "arn:aws:sso:::permissionSet/ssoins-8824c710b5ddb452/ps-6f8897f9e56fb805"
      + principal_id       = (known after apply)
      + principal_type     = "GROUP"
      + target_id          = "472286471787"
      + target_type        = "AWS_ACCOUNT"
    }

  # aws_ssoadmin_account_assignment.articles["Articles-Production-ReadOnly-762579868088"] will be created
  + resource "aws_ssoadmin_account_assignment" "articles" {
      + id                 = (known after apply)
      + instance_arn       = "arn:aws:sso:::instance/ssoins-8824c710b5ddb452"
      + permission_set_arn = "arn:aws:sso:::permissionSet/ssoins-8824c710b5ddb452/ps-6f8897f9e56fb805"
      + principal_id       = (known after apply)
      + principal_type     = "GROUP"
      + target_id          = "762579868088"
      + target_type        = "AWS_ACCOUNT"
    }

  # aws_ssoadmin_account_assignment.articles["Articles-Staging-Admin-729164266357"] will be created
  + resource "aws_ssoadmin_account_assignment" "articles" {
      + id                 = (known after apply)
      + instance_arn       = "arn:aws:sso:::instance/ssoins-8824c710b5ddb452"
      + permission_set_arn = "arn:aws:sso:::permissionSet/ssoins-8824c710b5ddb452/ps-37cc13ae63647ac6"
      + principal_id       = (known after apply)
      + principal_type     = "GROUP"
      + target_id          = "729164266357"
      + target_type        = "AWS_ACCOUNT"
    }

  # aws_ssoadmin_account_assignment.articles["Articles-Staging-ReadOnly-729164266357"] will be created
  + resource "aws_ssoadmin_account_assignment" "articles" {
      + id                 = (known after apply)
      + instance_arn       = "arn:aws:sso:::instance/ssoins-8824c710b5ddb452"
      + permission_set_arn = "arn:aws:sso:::permissionSet/ssoins-8824c710b5ddb452/ps-6f8897f9e56fb805"
      + principal_id       = (known after apply)
      + principal_type     = "GROUP"
      + target_id          = "729164266357"
      + target_type        = "AWS_ACCOUNT"
    }

Plan: 12 to add, 0 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"
Show Conftest results
20 tests, 20 passed, 0 warnings, 0 failures, 0 exceptions

Copy link
Contributor

@gcharest gcharest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! 🎉

@patheard patheard merged commit 88e1ad2 into main Apr 11, 2024
16 checks passed
@patheard patheard deleted the feat/aws-sso-articles branch April 11, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants